Redesigned top nav and footer #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 26, 2023 21:32
Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: Aaron Stephanus <[email protected]>
ghost
requested review from
cwillum,
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: Aaron Stephanus <[email protected]>
|
@ashwin-pc or @joshuarrrr - Can one of you please do a code review of this PR? Thanks. |
…d/collapse transitions instead of hardcoded values potentiating effortless change management Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: Aaron Stephanus <[email protected]>
|
The BUILD FREELY tagline in the footer in mobile view overlays onto other text and there is a hyperlink attached to the tagline, which appears underlined in mobile view. Request change: For mobile view, replace current logo/tagline with new vertical format svg (provided) and remove hyperlinks. SVG should use F4F8FB (OpenSky T3) as the graphic color.
|
added 2 commits
October 5, 2023 11:45
Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: Aaron Stephanus <[email protected]>
|
@maezieLoo I have followed up on the footer fixes. |
added 4 commits
October 5, 2023 14:00
Signed-off-by: Aaron Stephanus <[email protected]>
…to-top button Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: Aaron Stephanus <[email protected]>
Signed-off-by: Aaron Stephanus <[email protected]>
ghost
marked this pull request as draft
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-5113-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.1Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-5113-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.4Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.0 2.0
# Navigate to the new working tree
pushd ../.worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-5113-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.0Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.6 2.6
# Navigate to the new working tree
pushd ../.worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-5113-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.6
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.6Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-5113-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.8Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-5113-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.7Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.2 2.2
# Navigate to the new working tree
pushd ../.worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-5113-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.2
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.2Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.3 2.3
# Navigate to the new working tree
pushd ../.worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-5113-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.3Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.5 2.5
# Navigate to the new working tree
pushd ../.worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-5113-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.5
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.5Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-5113-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.9Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
* Ports over redesigned top banner header navigation, and footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides for search functionality Signed-off-by: Aaron Stephanus <[email protected]> * Adds Font Awesome for menu icons Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides and updated menu item configurations Signed-off-by: Aaron Stephanus <[email protected]> * Adds whitespace to fix SASS style rule causing Github action failure Signed-off-by: Aaron Stephanus <[email protected]> * Adds dynamic navigation submenu height determination for smooth expand/collapse transitions instead of hardcoded values potentiating effortless change management Signed-off-by: Aaron Stephanus <[email protected]> * Removes outdated message about old version release Signed-off-by: Aaron Stephanus <[email protected]> * Corrects padding, positioning, typography for the site footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds new footer logo Signed-off-by: Aaron Stephanus <[email protected]> * Sets footer legal copy right padding on mobile to that of the scroll-to-top button Signed-off-by: Aaron Stephanus <[email protected]> * Adds footer link styles Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts page layout to fit the new container width requirements Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile layout with new header and footer Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile navigation menu errors Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts padding Signed-off-by: Aaron Stephanus <[email protected]> * Removes commented out code Signed-off-by: Aaron Stephanus <[email protected]> * Updates top navigation menu items with latest from project site Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: astephanus <[email protected]> (cherry picked from commit dadb6b1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.10 2.10
# Navigate to the new working tree
pushd ../.worktrees/backport-2.10
# Create a new branch
git switch --create backport/backport-5113-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dadb6b1f148ce7438e5d7594fef2cf8b9c75c623
# Push it to GitHub
git push --set-upstream origin backport/backport-5113-to-2.10
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.10Then, create a pull request where the |
hdhalter
pushed a commit
that referenced
this pull request
Nov 7, 2023
* Ports over redesigned top banner header navigation, and footer * Adds style overrides for search functionality * Adds Font Awesome for menu icons * Adds style overrides and updated menu item configurations * Adds whitespace to fix SASS style rule causing Github action failure * Adds dynamic navigation submenu height determination for smooth expand/collapse transitions instead of hardcoded values potentiating effortless change management * Removes outdated message about old version release * Corrects padding, positioning, typography for the site footer * Adds new footer logo * Sets footer legal copy right padding on mobile to that of the scroll-to-top button * Adds footer link styles * Adjusts page layout to fit the new container width requirements * Fixes mobile layout with new header and footer * Fixes mobile navigation menu errors * Adjusts padding * Removes commented out code * Updates top navigation menu items with latest from project site --------- (cherry picked from commit dadb6b1) Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: astephanus <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hdhalter
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Ports over redesigned top banner header navigation, and footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides for search functionality Signed-off-by: Aaron Stephanus <[email protected]> * Adds Font Awesome for menu icons Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides and updated menu item configurations Signed-off-by: Aaron Stephanus <[email protected]> * Adds whitespace to fix SASS style rule causing Github action failure Signed-off-by: Aaron Stephanus <[email protected]> * Adds dynamic navigation submenu height determination for smooth expand/collapse transitions instead of hardcoded values potentiating effortless change management Signed-off-by: Aaron Stephanus <[email protected]> * Removes outdated message about old version release Signed-off-by: Aaron Stephanus <[email protected]> * Corrects padding, positioning, typography for the site footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds new footer logo Signed-off-by: Aaron Stephanus <[email protected]> * Sets footer legal copy right padding on mobile to that of the scroll-to-top button Signed-off-by: Aaron Stephanus <[email protected]> * Adds footer link styles Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts page layout to fit the new container width requirements Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile layout with new header and footer Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile navigation menu errors Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts padding Signed-off-by: Aaron Stephanus <[email protected]> * Removes commented out code Signed-off-by: Aaron Stephanus <[email protected]> * Updates top navigation menu items with latest from project site Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: astephanus <[email protected]> (cherry picked from commit dadb6b1)
hdhalter
added a commit
that referenced
this pull request
Nov 8, 2023
* Ports over redesigned top banner header navigation, and footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides for search functionality Signed-off-by: Aaron Stephanus <[email protected]> * Adds Font Awesome for menu icons Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides and updated menu item configurations Signed-off-by: Aaron Stephanus <[email protected]> * Adds whitespace to fix SASS style rule causing Github action failure Signed-off-by: Aaron Stephanus <[email protected]> * Adds dynamic navigation submenu height determination for smooth expand/collapse transitions instead of hardcoded values potentiating effortless change management Signed-off-by: Aaron Stephanus <[email protected]> * Removes outdated message about old version release Signed-off-by: Aaron Stephanus <[email protected]> * Corrects padding, positioning, typography for the site footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds new footer logo Signed-off-by: Aaron Stephanus <[email protected]> * Sets footer legal copy right padding on mobile to that of the scroll-to-top button Signed-off-by: Aaron Stephanus <[email protected]> * Adds footer link styles Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts page layout to fit the new container width requirements Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile layout with new header and footer Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile navigation menu errors Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts padding Signed-off-by: Aaron Stephanus <[email protected]> * Removes commented out code Signed-off-by: Aaron Stephanus <[email protected]> * Updates top navigation menu items with latest from project site Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: astephanus <[email protected]> (cherry picked from commit dadb6b1) Co-authored-by: astephanus <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Ports over redesigned top banner header navigation, and footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides for search functionality Signed-off-by: Aaron Stephanus <[email protected]> * Adds Font Awesome for menu icons Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides and updated menu item configurations Signed-off-by: Aaron Stephanus <[email protected]> * Adds whitespace to fix SASS style rule causing Github action failure Signed-off-by: Aaron Stephanus <[email protected]> * Adds dynamic navigation submenu height determination for smooth expand/collapse transitions instead of hardcoded values potentiating effortless change management Signed-off-by: Aaron Stephanus <[email protected]> * Removes outdated message about old version release Signed-off-by: Aaron Stephanus <[email protected]> * Corrects padding, positioning, typography for the site footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds new footer logo Signed-off-by: Aaron Stephanus <[email protected]> * Sets footer legal copy right padding on mobile to that of the scroll-to-top button Signed-off-by: Aaron Stephanus <[email protected]> * Adds footer link styles Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts page layout to fit the new container width requirements Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile layout with new header and footer Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile navigation menu errors Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts padding Signed-off-by: Aaron Stephanus <[email protected]> * Removes commented out code Signed-off-by: Aaron Stephanus <[email protected]> * Updates top navigation menu items with latest from project site Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: astephanus <[email protected]> (cherry picked from commit dadb6b1) Co-authored-by: astephanus <[email protected]> (cherry picked from commit b31a20a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hdhalter
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Ports over redesigned top banner header navigation, and footer * Adds style overrides for search functionality * Adds Font Awesome for menu icons * Adds style overrides and updated menu item configurations * Adds whitespace to fix SASS style rule causing Github action failure * Adds dynamic navigation submenu height determination for smooth expand/collapse transitions instead of hardcoded values potentiating effortless change management * Removes outdated message about old version release * Corrects padding, positioning, typography for the site footer * Adds new footer logo * Sets footer legal copy right padding on mobile to that of the scroll-to-top button * Adds footer link styles * Adjusts page layout to fit the new container width requirements * Fixes mobile layout with new header and footer * Fixes mobile navigation menu errors * Adjusts padding * Removes commented out code * Updates top navigation menu items with latest from project site --------- (cherry picked from commit dadb6b1) (cherry picked from commit b31a20a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: astephanus <[email protected]>
hdhalter
added a commit
that referenced
this pull request
Nov 8, 2023
hdhalter
added a commit
that referenced
this pull request
Nov 8, 2023
Naarcha-AWS
added a commit
that referenced
this pull request
Nov 9, 2023
This reverts commit dadb6b1.
Naarcha-AWS
added a commit
that referenced
this pull request
Nov 9, 2023
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Ports over redesigned top banner header navigation, and footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides for search functionality Signed-off-by: Aaron Stephanus <[email protected]> * Adds Font Awesome for menu icons Signed-off-by: Aaron Stephanus <[email protected]> * Adds style overrides and updated menu item configurations Signed-off-by: Aaron Stephanus <[email protected]> * Adds whitespace to fix SASS style rule causing Github action failure Signed-off-by: Aaron Stephanus <[email protected]> * Adds dynamic navigation submenu height determination for smooth expand/collapse transitions instead of hardcoded values potentiating effortless change management Signed-off-by: Aaron Stephanus <[email protected]> * Removes outdated message about old version release Signed-off-by: Aaron Stephanus <[email protected]> * Corrects padding, positioning, typography for the site footer Signed-off-by: Aaron Stephanus <[email protected]> * Adds new footer logo Signed-off-by: Aaron Stephanus <[email protected]> * Sets footer legal copy right padding on mobile to that of the scroll-to-top button Signed-off-by: Aaron Stephanus <[email protected]> * Adds footer link styles Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts page layout to fit the new container width requirements Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile layout with new header and footer Signed-off-by: Aaron Stephanus <[email protected]> * Fixes mobile navigation menu errors Signed-off-by: Aaron Stephanus <[email protected]> * Adjusts padding Signed-off-by: Aaron Stephanus <[email protected]> * Removes commented out code Signed-off-by: Aaron Stephanus <[email protected]> * Updates top navigation menu items with latest from project site Signed-off-by: Aaron Stephanus <[email protected]> --------- Signed-off-by: Aaron Stephanus <[email protected]> Signed-off-by: astephanus <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports the new design for site top banner header navigation, and site footer from the project website.
Also updates the menu item configuration data.
A note to code review. This is a port of a new design implementation from the project website where 1rem there != 1rem here. This repo uses a base theme that makes very greedy use of
!importantthat needed to be forcefully overridden using!importantdespite its nature as an antipattern, and the base theme makes use of REM units in media queries which also needed to be accounted for. So, there are visibly bad practices at play in the changes in this PR.This is an intermediate step towards impementing a new design entirely. In the interim we want to be at least aligned on having a header / footer that looks the same between the project website, and the documentation website, despite the kludges necessary to acheive this goal.
[...]._
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.